On 19.09.2019 17:09, Paul Durrant wrote:
>> -----Original Message-----
>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>> index fdb1e17f59..4cc077bb3f 100644
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3236,6 +3236,19 @@ static enum hvm_translation_result __hvm_copy(
>> return HVMTRANS_bad_gfn_to_mfn;
>> }
>>
>> + /*
>> + * In case a vm event was sent return paged_out so the emulation
>> will
>> + * stop with no side effect
>> + */
>> + if ( (flags & HVMCOPY_linear) &&
>> + unlikely(v->arch.vm_event) &&
>> + v->arch.vm_event->send_event &&
>> + hvm_monitor_check_p2m(addr, gfn, pfec, npfec_kind_with_gla) )
>> + {
>> + put_page(page);
>> + return HVMTRANS_bad_gfn_access;
>
> This doesn't match the comment above. Did you mean to return
> HVMTRANS_gfn_paged_out? I'm guessing not, in which case the comment needs to
> be fixed.
Yes, it seems I missed that but given that the return name will change I
will have the comment fixed in the next version. Thanks for pointing
this out.
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
