On 20.09.2019 10:50, Andrew Cooper wrote: > On 19/09/2019 11:37, Jan Beulich wrote: >> hvm_monitor_cpuid() expects the input registers, not two of the outputs. > > Perhaps worth nothing that this has been broken since its introduction > in c/s d05f1eb3741b85 ?
Ah, yes, I should have done this. I've added half a sentence. >> However, once having made the necessary adjustment, the SVM and VMX >> functions are so similar that they should be folded (thus avoiding >> further similar asymmetries to get introduced). Use the best of both >> worlds by e.g. using "curr" consistently. This then being the only >> caller of hvm_check_cpuid_faulting(), fold in that function as well. >> >> Signed-off-by: Jan Beulich <[email protected]> > > Reviewed-by: Andrew Cooper <[email protected]> Thanks. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
