Anthony PERARD writes ("Re: [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb
and iommu_memkb defaulting into libxl"):
> On Fri, Oct 04, 2019 at 04:17:06PM +0100, Ian Jackson wrote:
> > @@ -862,6 +864,30 @@ static void domcreate_destruction_cb(libxl__egc *egc,
> > libxl__domain_destroy_state *dds,
> > int rc);
> >
> > +static _Bool ok_to_default_memkb_in_create(libxl__gc *gc)
>
> Is there a reason to use _Bool instead of `bool'? It would be the first
> _Bool in libxl.
I had the wrong head on. (I've been writing code recently where
`bool' wasn't available.)
> > + return CTX->libxl_domain_need_memory_0x041200_called &&
> > + !CTX->libxl_domain_need_memory_called;
>
> I think the logic here is inverted.
You are right.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
