Hi Ian,
On 18/10/2019 16:51, Ian Jackson wrote:
Julien Grall writes ("Re: [XEN PATCH for-4.13 v5 10/10] libxl/xl: Overhaul
passthrough setting logic"):
On 18/10/2019 16:06, Ian Jackson wrote:
...
+ if (c_info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT) {
+ LOGD(ERROR, domid,
+ "passthrough=\"sync_pt\" not supported on ARM\n");
+ rc = ERROR_INVAL;
+ goto out;
+ }
Would it make sense to use a switch case or whitelist here? So we don't end up
to slip through if a new type is added and unsupported on Arm.
I wouldn't mind changing this to
c_info->passthrough != LIBXL_PASSTHROUGH_SHARE_PT
I think it would need to be
c_info->passthrough != LIBXL_PASSTHROUGH_SHARE_PT && c_info->passthrough !=
LIBXL_PASSTHROUGH_DISABLED.
Although it's a shame you're raising this now. This code has been
like this since v3. Would you mind if we did this as a followup
patch ?
Sorry I haven't been really good at reviewing this week :(.
I am happy if this is done in a follow-up.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
