On 16.10.2019 12:53, Julien Grall wrote: > virt_to_maddr() is using the hardware page-table walk instructions to > translate a virtual address to physical address. The function should > only be called on virtual address mapped. > > _end points past the end of Xen binary and may not be mapped when the > binary size is page-aligned. This means virt_to_maddr() will not be able > to do the translation and therefore crash Xen. > > Note there is also an off-by-one issue in this code, but the panic will > trump that. > > Both issues can be fixed by using _end - 1 in the check. > > Signed-off-by: Julien Grall <[email protected]> > Release-acked-by: Juergen Gross <[email protected]> > > --- > > Cc: Andrew Cooper <[email protected]> > Cc: George Dunlap <[email protected]> > Cc: Ian Jackson <[email protected]> > Cc: Jan Beulich <[email protected]> > Cc: Julien Grall <[email protected]> > Cc: Konrad Rzeszutek Wilk <[email protected]> > Cc: Stefano Stabellini <[email protected]> > Cc: Tim Deegan <[email protected]> > Cc: Wei Liu <[email protected]> > > x86 seems to be affected by the off-by-one issue. Jan, Andrew?
Indeed. I'm in the process of making a patch. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
