On 11/26/19 9:01 AM, Jan Beulich wrote: >>>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >>>> index a03e80e5984a..1b69eb75cb20 100644 >>>> --- a/xen/include/public/domctl.h >>>> +++ b/xen/include/public/domctl.h >>>> @@ -163,6 +163,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_getdomaininfo_t); >>>> #define XEN_DOMCTL_PFINFO_LTAB_MASK (0xfU<<28) >>>> >>>> /* XEN_DOMCTL_getpageframeinfo3 */ >>>> +/* >>>> + * Both value `num' and `array' are modified by the hypercall to allow >>>> + * preemption. >>> >>> s/are/may be/ ? >> >> I don't think the distinction is necessary. How would that be useful to >> know that both values may not be modified? I though the goal of the >> added description was to warn against reusing the values after calling >> the hypercall. > > If you write "are", you're saying that it _will_ be modified, i.e. a > caller may (even if just for some sanity checking) verify that the fields > indeed did change. I think wording in the public headers in particular > should precisely represent all possible behaviors.
FWIW I agree with this. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
