> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 29 November 2019 10:29
> To: Durrant, Paul <pdurr...@amazon.com>
> Cc: Andrew Cooper <andrew.coop...@citrix.com>; Anthony PERARD
> <anthony.per...@citrix.com>; George Dunlap <george.dun...@citrix.com>;
> Roger Pau Monné <roger....@citrix.com>; Volodymyr Babchuk
> <volodymyr_babc...@epam.com>; George Dunlap <george.dun...@eu.citrix.com>;
> Ian Jackson <ian.jack...@eu.citrix.com>; Marek Marczykowski-Górecki
> <marma...@invisiblethingslab.com>; Stefano Stabellini
> <sstabell...@kernel.org>; xen-devel@lists.xenproject.org; Konrad Rzeszutek
> Wilk <konrad.w...@oracle.com>; Julien Grall <jul...@xen.org>; Wei Liu
> <w...@xen.org>
> Subject: Re: [PATCH-for-4.13 v5] Rationalize max_grant_frames and
> max_maptrack_frames handling
>
> On 29.11.2019 11:22, Jan Beulich wrote:
> > On 28.11.2019 17:52, Paul Durrant wrote:
> >> --- a/xen/common/grant_table.c
> >> +++ b/xen/common/grant_table.c
> >> @@ -84,11 +84,40 @@ struct grant_table {
> >> struct grant_table_arch arch;
> >> };
> >>
> >> +static int parse_gnttab_limit(const char *param, const char *arg,
> >> + unsigned int *valp)
> >> +{
> >> + const char *e;
> >> + unsigned long val;
> >> +
> >> + val = simple_strtoul(arg, &e, 0);
> >> + if ( *e )
> >> + return -EINVAL;
> >> +
> >> + if ( val > INT_MAX )
> >> + return -ERANGE;
> >> +
> >> + return 0;
> >> +}
> >
> > *valp doesn't get written to anymore.
That was intentional, given Juergen's comment...
> With this fixed (and no new
> > issues introduced ;-) ) hypervisor side
> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
>
> And I guess I should have clarified: I'd be fine adding the missing
> assignment while committing, provided the tools side won't require
> any changes.
...but if we want to allow dom0 to set itself up for INT_MAX frames in the
event of a bad value then I'm not objecting.
Paul
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
