On 12/12/2019 18:27, Anthony PERARD wrote: > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index ff6c0f5cdd18..8c846261d241 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -78,7 +78,7 @@ > #define __must_be_array(a) \ > BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > > -#ifdef GCC_HAS_VISIBILITY_ATTRIBUTE > +#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE > /* Results in more efficient PIC code (no indirections through GOT or PLT). > */ > #pragma GCC visibility push(hidden)
(I realise we are getting into archaeology, but) Why do we have this as a pragma gcc? Surely it would be simpler to just feed -fvisibility=hidden into CFLAGS? Ack for the overall change, but I expect we can clean this up a bit more as well. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
