On 12/12/2019 17:32, George Dunlap wrote: > put_page_from_l[234]e have identical functionality for devalidating an > N-1 entry which is a pagetable. But mystifyingly, they duplicate the > code in slightly different arrangements that make it hard to tell that > it's the same.
ITYM "this code has grown rather more organically than most" :) > Create a new function, put_pt_page(), which handles the common > functionality; and refactor all the functions to be symmetric, > differing only in the level of pagetable expected (and in whether they > handle superpages). > > No functional change intended. > > Signed-off-by: George Dunlap <george.dun...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> The only thing I can see is that the l2 case gains an assertion, but this looks to be correct. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
