On 16/12/2019 09:47, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 10:48:01PM +0000, Igor Druzhinin wrote: >> They either need to be transformed to atomics to work correctly >> (currently they left unprotected for HVM domains) or dropped entirely > ^ are used >> as taking a per-domain spinlock is too expensive for high-vCPU count >> domains even for debug build given this lock is taken too often. >> >> Choose the latter as they are not extremely important anyway. >> >> Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> > I don't find those counters specially useful TBH, but I'm not sure whether > others find them useful. The change LGTM, so: > > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Jan and I already considered dropping them once (because of the HVM observation), but didn't find any harm with keeping them, seeing as they were diagnostic-only. I suspect they were put in for PVRDTSCP which has since been dropped. We now have a clear case where dropping them is of use to Xen. Acked-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
