promote_l4_table() is different from its lower level helpers, by having an extra return path out of the middle of the loop in the case of a failure.
Break from the loop, which is consistent with the other helpers, and functionally equivalent. Signed-off-by: Andrew Cooper <[email protected]> --- CC: Jan Beulich <[email protected]> CC: George Dunlap <[email protected]> --- xen/arch/x86/mm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index c14c677a62..594f1bd290 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1856,10 +1856,7 @@ static int promote_l4_table(struct page_info *page) } } if ( rc < 0 ) - { - unmap_domain_page(pl4e); - return rc; - } + break; pl4e[i] = adjust_guest_l4e(l4e, d); } -- 2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
