On Thu, Dec 19, 2019 at 11:51 AM Andrew Cooper <andrew.coop...@citrix.com> wrote: > > On 19/12/2019 16:21, Tamas K Lengyel wrote: > >>> @@ -437,25 +441,29 @@ static inline void mem_sharing_gfn_destroy(struct > >>> page_info *page, > >>> xfree(gfn_info); > >>> } > >>> > >>> -static struct page_info* mem_sharing_lookup(unsigned long mfn) > >>> +static inline struct page_info* mem_sharing_lookup(unsigned long mfn) > >> Seeing as this is cleanup, the position of the * can move. Similarly, > >> it shouldn't gain an inline. > >> > >> I can fix all of this up on commit (and a few other brace position > >> issues) if you want, to save reworking a trivial v2. > >> > > Provided nothing else is outstanding with the patch and it can be > > committed I would certainly appreciate that. > > I've pushed this and the previous patch, with some further fixups that I > spotted. > > Hopefully the rebase won't be an issue.
Great! There were quite a few conflicts in the rebase so I hope I don't accidentally revert some of your new fixes :) Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
