On Thu, Jan 09, 2020 at 11:15:05AM +0000, Paul Durrant wrote: > Running 'make distclean' under tools will currently result in: > > tools/Rules.mk:245: *** You have to run ./configure before building or > installing the tools. Stop. > > This patch adds 'distclean', 'subdir-distclean%' and 'subdir-clean%' to > no-configure-targets, which allows 'make distclean' to run to completion. > > Signed-off-by: Paul Durrant <pdurr...@amazon.com>
Fixes: 00691c6c90b Sorry for not noticing the breakage while reviewing that patch. Is there a way to pattern match all targets containing "clean"? (Would have looked into it myself but -ETIME today) > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Wei Liu <w...@xen.org> > --- > tools/Rules.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/Rules.mk b/tools/Rules.mk > index 31cf419ef4..52f47be3f8 100644 > --- a/tools/Rules.mk > +++ b/tools/Rules.mk > @@ -239,7 +239,7 @@ subdir-all-% subdir-clean-% subdir-install-% > subdir-uninstall-%: .phony > subdir-distclean-%: .phony > $(MAKE) -C $* distclean > > -no-configure-targets := clean subtree-force-update-all %-dir-force-update > +no-configure-targets := distclean subdir-distclean% clean subdir-clean% > subtree-force-update-all %-dir-force-update > ifeq (,$(filter $(no-configure-targets),$(MAKECMDGOALS))) > $(XEN_ROOT)/config/Tools.mk: > $(error You have to run ./configure before building or installing the > tools) > -- > 2.20.1 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
