On 07/01/2020 16:30, Jan Beulich wrote: > On 07.01.2020 17:16, Jan Beulich wrote: >> On 06.01.2020 16:54, Andrew Cooper wrote: >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -584,21 +584,24 @@ static void __init efi_arch_memory_setup(void) >>> if ( !efi_enabled(EFI_LOADER) ) >>> return; >>> >>> - /* Initialise L2 identity-map and boot-map page table entries (16MB). >>> */ >>> + /* >>> + * Map Xen into the directmap (NX, needed for early-boot pagetable >>> + * handling/walking), and identity map Xen into bootmap (X, needed for >>> the >>> + * transition from the EFI pagetables to Xen), using 2M superpages. >>> + */ >> How does NX vs X matter for the code below here? PAGE_HYPERVISOR and >> __PAGE_HYPERVISOR, as used below, differ by just _PAGE_GLOBAL. Did >> you mean to make further changes?
Nope. The comments were actually correct (and the code, remained correct). PAGE_HYPERVISOR and __PAGE_HYPERVISOR really do differ by NX as well, outside of asm code. I'm going to fix this because its too complicated to reason about. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
