On 14/01/2020 11:48, Wei Liu wrote:
> On Fri, Jan 10, 2020 at 05:59:44PM +0000, Andrew Cooper wrote:
>> On 10/01/2020 02:30, Tamas K Lengyel wrote:
>>> The library has been largely untouched for over a decade at this point, it 
>>> is
>>> undocumented and it's unclear what it was originally used for. Remove it 
>>> from
>>> tree, if anyone needs it in the future it can be carved out from git 
>>> history.
>>>
>>> Signed-off-by: Tamas K Lengyel <ta...@tklengyel.com>
>> Hmm - this is a little awkward.  You remove yourself as maintainer of
>> this code, then delete it.
>>
>> I suspect what you want to do is have patch 1 simply add tools/test
>> saying "include other memshr content", and this patch delete
>> tools/memshr including the entry in the maintainers file.  (Can be fixed
>> up on commit of course, seeing as this is the only issue.)
>>
>> Overall, I agree with the change, but it will need a tools ack.
>>
> I mostly agree with Tamas' assessment. No point in keeping dead and
> unused code in tree.
>
> Acked-by: Wei Liu <w...@xen.org>

Cool.  If noone else gets to it, I'll see about committing this series
and shuffling the order of operations.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to