On 14/01/2020 17:33, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH 19/20] tools/libxl: Re-position CPUID handling
> during domain construction"):
>> CPUID handling needs to be earlier in construction. Move it from its current
>> position in libxl__build_post() to libxl__build_pre() for fresh builds, and
>> libxl__srm_callout_callback_static_data_done() for the migration/resume case.
>>
>> In the migration case, take account of XGR_SDD_MISSING_CPUID.
> Is it possible to split out the change to the sequencing, from the new
> functionality ?
Not easily, no.
While libxc is discarding the CPUID record, libxl needs to make the
calls unconditionally for VMs to function.
If you recall, an early patch in the series leaves a todo in libxc
(which is there for this very bisection reason), which passes
XGR_SDD_MISSING_CPUID back unconditionally (making this patch alone
effectively no net change).
A subsequence patch makes the passing of XGR_SDD_MISSING_CPUID
conditional on the content in the stream, now that we are no longer
discarding the CPUID records found.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
