On 15.01.2020 18:00, Anthony PERARD wrote: > --- a/xen/Kconfig > +++ b/xen/Kconfig > @@ -4,9 +4,25 @@ > # > mainmenu "Xen/$(SRCARCH) $(XEN_FULLVERSION) Configuration" > > +source "scripts/Kconfig.include" > + > config BROKEN > bool > > +config CC_IS_GCC > + def_bool $(success,$(CC) --version | head -n 1 | grep -q gcc) > + > +config GCC_VERSION > + int > + default $(shell,$(BASEDIR)/scripts/gcc-version.sh $(CC)) > + > +config CC_IS_CLANG > + def_bool $(success,$(CC) --version | head -n 1 | grep -q clang) > + > +config CLANG_VERSION > + int > + default $(shell,$(BASEDIR)/scripts/clang-version.sh $(CC))
I continue to be unhappy about the redundancy, but I will accept it if others indeed think this is helpful. However, I don't see then why the setting of CC_IS_* need another shell invocation each - this could just be *_VERSION > 0 then, seeing that the scripts already to a respective grep of the --version output. Even better would imo be, as suggested before, a "depends on CC_IS_*" on each *_VERSION. As a nit - common style elsewhere would suggest that there ought to be a blank after the commas in $(macro, ...) invocations. This would then extend to Kconfig.include as well, unless that's a largely verbatim inherited file. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel