On 27/01/2020 09:38, Julien Grall wrote:
> From: Julien Grall <jgr...@amazon.com>
>
> Commit 8916fcf4577 "x86/domain: compile with lock_profile=y enabled"
> allowed the struct domain to use more than a PAGE_SIZE (i.e 4096).
> However, the function free_domheap_struct() will only free the first
> page.
>
> We could modify the free part to free the correct number of pages, but
> the structure has been fitting in a page (even with lock profile
> enabled) since commit 428607a410 "x86: shrink 'struct domain', was
> already PAGE_SIZE" (part of Xen 4.7).
>
> Therefore, the specific case for lock profile is now removed.
>
> This is not a security issue because struct domain can only be bigger
> than a page size for lock profiling. The feature can only be selected
> in DEBUG and EXPERT mode.
>
> Fixes: 8916fcf4577 ("x86/domain: compile with lock_profile=y enabled")
> Reported-by: David Woodhouse <d...@amazon.co.uk>
> Signed-off-by: Julien Grall <jgr...@amazon.com>Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Thanks. Much better! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
