> -----Original Message----- > From: Ian Jackson [mailto:ian.jack...@citrix.com] > Sent: 27 January 2020 15:49 > To: Jürgen Groß <jgr...@suse.com> > Cc: Durrant, Paul <pdurr...@amazon.co.uk>; xen-devel@lists.xenproject.org; > Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Jan Beulich <jbeul...@suse.com>; Julien Grall > <jul...@xen.org>; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano > Stabellini <sstabell...@kernel.org>; Wei Liu <w...@xen.org> > Subject: Re: [PATCH] docs: retrospectively add XS_DIRECTORY_PART to the > xenstore protocol... > > Jürgen Groß writes ("Re: [PATCH] docs: retrospectively add > XS_DIRECTORY_PART to the xenstore protocol..."): > > On 27.01.20 16:33, Ian Jackson wrote: > > > Paul Durrant writes ("[PATCH] docs: retrospectively add > XS_DIRECTORY_PART to the xenstore protocol..."): > > >> ... specification. > > >> > > >> This was added by commit 0ca64ed8 "xenstore: add support for > > >> reading directory with many children" but not added to the > > >> specification at that point. A version of xenstored supporting the > > >> command was first released in Xen 4.9. > > > > > > Thanks for documenting this. A docs fix like this should be > > > backported if it applies, IMO. > > > > > > Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> > > > Backport: 4.9+ > > > > > > I will commit it to staging momentarily. > > > > > >> +DIRECTORY_PART <path>|<index|> <child-leaf-name>|* > > >> + Performs the same function as DIRECTORY, but returns a > > >> + sub-list of children starting at <index> in the overall > > >> + child list and less than or equal to XENSTORE_PAYLOAD_MAX > > >> + octets in length. If <index> is beyond the end of the > > >> + overall child list then the returned sub-list will be > > >> + empty. > > > > > > I wonder if it should be somehow made more explicit that `index' is > > > a count of directory entries, not bytes. Maybe this is obvious. > > > > But this is wrong. It is bytes, and the generation count returned is > > missing (see my original patch back in 2017). > > Sorry for being too quick. I have reverted my commit. >
Since I got it wrong, I suggest just taking Juergen's original text (which I was unaware of before). It seems ok to me. Paul > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
