> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 29 January 2020 11:13 > To: Durrant, Paul <pdurr...@amazon.co.uk> > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > <andrew.coop...@citrix.com>; George Dunlap <george.dun...@eu.citrix.com>; > Ian Jackson <ian.jack...@eu.citrix.com>; Julien Grall <jul...@xen.org>; > Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano Stabellini > <sstabell...@kernel.org>; Wei Liu <w...@xen.org> > Subject: Re: [PATCH v5 2/4] mm: modify domain_adjust_tot_pages() to better > handle a zero adjustment > > On 29.01.2020 11:16, Paul Durrant wrote: > > Currently the function will pointlessly acquire and release the global > > 'heap_lock' in this case. > > > > NOTE: No caller yet calls domain_adjust_tot_pages() with a zero 'pages' > > argument, but a subsequent patch will make this possible. > > With this memory_exchange(), as previously indicated, now needlessly > prevents the call when !dec_count. I do think, as said there, that > together with the addition here then redundant checks in callers > should be dropped (and as it looks the named one is the only one). >
Ok, yes I missed that. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel