> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 30 January 2020 16:29
> To: Durrant, Paul <pdurr...@amazon.co.uk>
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
> <andrew.coop...@citrix.com>; Wei Liu <w...@xen.org>; Roger Pau Monné
> <roger....@citrix.com>; George Dunlap <george.dun...@eu.citrix.com>; Ian
> Jackson <ian.jack...@eu.citrix.com>; Julien Grall <jul...@xen.org>; Konrad
> Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano Stabellini
> <sstabell...@kernel.org>; Tim Deegan <t...@xen.org>
> Subject: Re: [PATCH v8 2/4] add a domain_tot_pages() helper function
>
> On 30.01.2020 15:57, Paul Durrant wrote:
> > --- a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> > @@ -218,7 +218,7 @@ void dump_pageframe_info(struct domain *d)
> >
> > printk("Memory pages belonging to domain %u:\n", d->domain_id);
> >
> > - if ( d->tot_pages >= 10 && d->is_dying < DOMDYING_dead )
> > + if ( domain_tot_pages(d) >= 10 && d->is_dying < DOMDYING_dead )
>
> Before I go any further - are you simply replacing _all_
> ->tot_pages uses by the new helper?
Basically, apart from domain_adjust_tot_pages(), yes.
> In the case here, for
> example, I don't think this is what we want.
>
Why not? I would have thought any 'extra' pages would always be of interest.
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
