Andrew Cooper writes ("Re: [PATCH v2 07/17] libxc/restore: STATIC_DATA_END
inference for v2 compatibility"):
> On 24/02/2020 17:32, Ian Jackson wrote:
> > These 17 lines appears twice, in basically identical form. Could it
> > be refactored ?
>
> Not really, no.
>
> The error handling (i.e. half of those 17 lines) is different, making it
> somewhat awkward to fit into a static inline.
You could handle that with a small bit of code around one of the call
sites to adjust the error handling. (Also, what a mess, but I guess
we're here now...)
> More importantly however, by design, common code can't call
> arch-specific code without a restore_ops hook. Deduping these would
> require breaking the restriction which is currently doing a decent job
> of keeping x86-isms out of common code.
I'm afraid you're going to have to explain that to me at a bit greater
length. The biggest thing that is confusing me about your statement
here is that your patch is indeed adding x86-specific code to a common
file. But also I don't understand the comment about restore_ops
hooks - do you mean something in restore_callbacks ?
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
