Roger Pau Monne writes ("[PATCH OSSTEST v5 4/5] examine: detect IOMMU
availability and add it as a hostflag"):
> Introduce a new test to check for iommu availability and add it as a
> hostflag if found.
...
> +our $has_iommu = $info =~ /directio/;
I think this regexp is too lax. For example, if the Xen command line
had something mentioning `directio' it would always say `yes'...
This appears in virt_caps, right ? So I think you want
+our $has_iommu = $info =~ /^virt_caps\s*:.*\sdirectio\s/m;
or some such. (Untested.)
Sorry for only spotting this now. Otherwise this LGTM.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
