> > +static int bring_up_vcpus(struct domain *cd, struct domain *d)
> > +{
> > + unsigned int i;
> > + int ret = -EINVAL;
>
> Nit: you can get rid of ret...
>
> > +
> > + if ( d->max_vcpus != cd->max_vcpus ||
> > + (ret = cpupool_move_domain(cd, d->cpupool)) )
> > + return ret;
>
> ...and just return -EINVAL here. Seeing as it's not used anywhere
> else.
>It is actually still needed, note that we store the return value of cpupool_move_domain in it. Tamas
