> -----Original Message-----
> From: Julien Grall <jul...@xen.org>
> Sent: 20 April 2020 18:26
> To: Paul Durrant <p...@xen.org>; xen-devel@lists.xenproject.org
> Cc: Paul Durrant <pdurr...@amazon.com>; Daniel De Graaf
> <dgde...@tycho.nsa.gov>; Ian Jackson
> <ian.jack...@eu.citrix.com>; Wei Liu <w...@xen.org>; Andrew Cooper
> <andrew.coop...@citrix.com>; George
> Dunlap <george.dun...@citrix.com>; Jan Beulich <jbeul...@suse.com>; Stefano
> Stabellini
> <sstabell...@kernel.org>
> Subject: Re: [PATCH v2 2/5] xen/common/domctl: introduce
> XEN_DOMCTL_get/setdomaincontext
>
> Hi Paul,
>
> On 07/04/2020 18:38, Paul Durrant wrote:
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index 1ad34c35eb..8ab39acf0c 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -38,7 +38,7 @@
> > #include "hvm/save.h"
> > #include "memory.h"
> >
> > -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000012
> > +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000013
> >
> > /*
> > * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
> > @@ -1129,6 +1129,44 @@ struct xen_domctl_vuart_op {
> > */
> > };
> >
> > +/*
> > + * Get/Set domain PV context. The same struct xen_domctl_domaincontext
>
> I think you want to update the comments to match the split.
Oh yes.
>
> > + * is used for both commands but with slightly different field semantics
> > + * as follows:
>
> Reviewed-by: Julien Grall <jgr...@amazon.com>
>
Thanks,
Paul
>
> Cheers,
>
>
> --
> Julien Grall
