On 30/04/2020 12:09, Jan Beulich wrote: > On 30.04.2020 11:59, Andrew Cooper wrote: >> Fam19h is very similar to Fam17h in these regards. >> >> Signed-off-by: Andrew Cooper <[email protected]> > Reviewed-by: Jan Beulich <[email protected]>
Thanks. > > Nevertheless a question: > >> --- a/xen/arch/x86/cpu/microcode/amd.c >> +++ b/xen/arch/x86/cpu/microcode/amd.c >> @@ -125,6 +125,7 @@ static bool_t verify_patch_size(uint32_t patch_size) >> max_size = F16H_MPB_MAX_SIZE; >> break; >> case 0x17: >> + case 0x19: >> max_size = F17H_MPB_MAX_SIZE; >> break; > Didn't you indicate to me the other day that the upper bound would > grow? That was a very non-specific patch to Linux. I've asked around, and the answer seems to be 4800. Are you happy for your review to stand with adding a new F19H_MPB_MAX_SIZE define to this effect? ~Andrew
