On 5/18/20, Jürgen Groß <jgr...@suse.com> wrote: > On 18.05.20 11:52, Denis Kirjanov wrote: >> On 5/18/20, Jürgen Groß <jgr...@suse.com> wrote: >>> On 18.05.20 10:24, Denis Kirjanov wrote: >>>> The patch adds a new extra type to be able to diffirentiate >>>> between RX responses on xen-netfront side with the adjusted offset >>>> required for XDP processing. >>>> >>>> For Linux the offset value is going to be passed via xenstore. >>> >>> Why? I can only see disadvantages by using a different communication >>> mechanism. >> I see it like other features passed through xenstore and it requires >> less changes to >> other structures with the same final result. > > This is okay as long there is no Xenstore interaction required when the > interface has been setup completely (i.e. only defining the needed > offset for XDP is fine, enabling/disabling XDP at runtime should not be > done via Xenstore IMO). I've checked netfront-<--->netback interaction and found no problems with it. Paul found an issue that the value of the netfront state hasn't been re-read (during unbind-bind sequence in dom0) and I've fixed it the patch for the guest
> > And please, no guest type special casing. Please replace "Linux" by e.g. > "The guest" (with additional tweaking of the following sentence). Oh, just sent v2. I'll fix a comment. > > > Juergen >
