On Mon, May 25, 2020 at 6:36 PM Jason Andryuk <[email protected]> wrote: > > On Sun, May 24, 2020 at 10:50 PM Jason Andryuk <[email protected]> wrote: > > > > This series addresses some Coverity reports. To handle closing FDs, a > > state struct is introduced to track FDs closed in both main() and > > data_loop(). > > I've realized the changes here are insufficient to handle the FD > leaks. That is, the accept()-ed FDs need to be closed inside the for > loop so they aren't leaked with each iteration. I'll re-work for a > v2.
So it turns out this series doesn't leak FDs in the for loop. FDs are necessarily closed down in data_loop() when the read() returns 0. The only returns from data_loop() are after the FDs have been closed. data_loop() and some of the functions it calls will call exit(1) on error, but that won't leak FDs. Please review this series. Sorry for the confusion. Regards, Jason
