On 02.06.2020 14:58, Juergen Gross wrote: > Commit 58263ed7713e ("xen: add /buildinfo/config entry to hypervisor > filesystem") added a dependency to .config, but the hypervisor's build > config could be have another name via setting KCONFIG_CONFIG. > > Fix that by using $(KCONFIG_CONFIG) instead. Additionally reference > the config file via $(XEN_ROOT) instead of a relative path. > > Reported-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Juergen Gross <jgr...@suse.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> albeit ... > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -75,7 +75,8 @@ obj-$(CONFIG_UBSAN) += ubsan/ > obj-$(CONFIG_NEEDS_LIBELF) += libelf/ > obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ > > -config.gz: ../.config > +CONF_FILE := $(if $(patsubst > /%,,$(KCONFIG_CONFIG)),$(XEN_ROOT)/xen/$(KCONFIG_CONFIG),$(KCONFIG_CONFIG)) ... I'll be tempted to shorten this to CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(XEN_ROOT)/xen/)$(KCONFIG_CONFIG) Jan