> -----Original Message----- > From: Jürgen Groß <jgr...@suse.com> > Sent: 09 June 2020 10:06 > To: p...@xen.org; 'Olaf Hering' <o...@aepfle.de>; 'Paul Durrant' > <xadimg...@gmail.com> > Cc: xen-devel@lists.xenproject.org; 'Ian Jackson' > <ian.jack...@eu.citrix.com>; 'Wei Liu' <w...@xen.org>; > 'Tim Deegan' <t...@xen.org> > Subject: Re: [PATCH v1] kdd: remove zero-length arrays > > On 09.06.20 11:04, Paul Durrant wrote: > >> -----Original Message----- > >> From: Olaf Hering <o...@aepfle.de> > >> Sent: 09 June 2020 10:00 > >> To: Paul Durrant <xadimg...@gmail.com> > >> Cc: p...@xen.org; xen-devel@lists.xenproject.org; 'Ian Jackson' > >> <ian.jack...@eu.citrix.com>; 'Tim > >> Deegan' <t...@xen.org>; 'Wei Liu' <w...@xen.org> > >> Subject: Re: [PATCH v1] kdd: remove zero-length arrays > >> > >> Am Tue, 9 Jun 2020 09:55:52 +0100 > >> schrieb Paul Durrant <xadimg...@gmail.com>: > >> > >>> Is it not sufficient to just change the declaration of payload in kdd_pkt > >>> from [0] to []? > >> > >> AFAIR this lead to compile errors. > >> > > > > OOI which compiler (might be worth mentioning in the commit comment too, > > for reference)? I'm not > seeing a problem. > > We don't use array[] in public headers, but AFAIK using them internally > is fine. >
Yeah, we have XEN_FLEX_ARRAY_DIM for public headers. Paul > > Juergen
