On Tue, Jun 16, 2020 at 05:21:20PM +0200, Michał Leszczyński wrote: > Guest IPT state will be preserved across vmentry/vmexit using > this structure.
I think you should squash this patch with a patch where the structure it's actually used. > Signed-off-by: Michal Leszczynski <michal.leszczyn...@cert.pl> > --- > xen/arch/x86/hvm/vmx/vmx.c | 2 ++ > xen/include/asm-x86/hvm/vmx/vmcs.h | 10 ++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index a91bbdb798..97104c319e 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -471,6 +471,8 @@ static int vmx_vcpu_initialise(struct vcpu *v) > > vmx_install_vlapic_mapping(v); > > + v->arch.hvm.vmx.ipt_state = NULL; Nit: there's no need to init this to NULL, since the structure is zeroed on allocation. Thanks, Roger.
