> -----Original Message-----
> From: Ian Jackson <ian.jack...@citrix.com>
> Sent: 18 June 2020 16:56
> To: Paul Durrant <xadimg...@gmail.com>
> Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org>; Jason Andryuk
> <jandr...@gmail.com>; Olaf Hering
> <o...@aepfle.de>; xen-devel <xen-devel@lists.xenproject.org>; Wei Liu
> <w...@xen.org>
> Subject: Re: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function
> declarations
>
> Samuel Thibault writes ("Re: [PATCH v1] stubdom/vtpm: add extern to function
> declarations"):
> > Jason Andryuk, le mer. 17 juin 2020 09:35:52 -0400, a ecrit:
> > > On Wed, Jun 17, 2020 at 2:10 AM Olaf Hering <o...@aepfle.de> wrote:
> > > >
> > > > Code compiled with gcc10 will not link properly due to multiple
> > > > definition of the same function.
> > > >
> > > > Signed-off-by: Olaf Hering <o...@aepfle.de>
> > >
> > > Reviewed-by: Jason Andryuk <jandr...@gmail.com>
> >
> > Acked-by: Samuel Thibault <samuel.thib...@ens-lyon.org>
>
> Reviewed-by: Ian Jackson <ian.jack...@eu.citrix.com>
>
> Thanks. I have confirmed that these symbols look to be defined (in
> tpm/tpm_emulator_extern.c). So the patch is correct.
>
> I think this is 4.14 material. Paul ?
Agreed.
Release-acked-by: Paul Durrant <p...@xen.org>
>
> We should also consider it for backports. How far back do we need
> to go ?
>
> Ian.
