On Sat, Jul 04, 2020 at 04:49:17PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This is the second time I try to replace a magic typename string > by a constant, and Zoltan warns me this is counter productive as > "hw/usb.h" pulls in an insane amount of code. > > Time to give the usb subsystem some love and move forward. > > This series can be decomposed as follow: > > 1-2: preliminary machine cleanups (arm/ppc) > 3-13: usb related headers cleanups > 14-15: usb quirks cleanup > 16-18: refactor usb_get_dev_path() to add usb_get_port_path() > 19: let spapr use usb_get_port_path() to make USBDevice opaque > 20: extract the public USB API (for machine/board/soc) > 21: make the older "usb.h" internal to hw/usb/ > 22-25: use TYPENAME definitions > 26: cover dwc2 in MAINTAINERS > > Please review.
Looks good overall, I don't fell like squeezing this into 5.1 though. Can you repost (with the few comments addressed) once 5.2 is open for development in roughly a month? thanks, Gerd