On 27/08/2020 06:21, Jürgen Groß wrote:
On 26.08.20 20:37, Julien Grall wrote:
"Usually" is a bit gross here. The only generic call site I could find
is xenbus_grant_ring(). All other instances (I counted 22) are not
generic at all.
will only catch one instance and it means we would have to fix the
first instance and then re-run to catch the others.
So I think we want to switch to WARN_ON() here.
No, please don't. In case there would be a frequent path the result
would be a basically unusable system due to massive console clobbering.
Right, but if that's really happenning then you have a much bigger
problem on your platform because the address returned will be invalid.
So I still don't see the advantage of WARN_ON_ONCE() here.
Cheers,
Juergen
--
Julien Grall
