On Wed, 7 Oct 2020, Christoph Hellwig wrote:
> On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote:
> > OK, this makes a lot of sense, and I like the patch because it makes the
> > swiotlb interface clearer.
> >
> > Just one comment below.
> >
>
> > > +phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t
> > > orig_addr,
> > > + size_t mapping_size, size_t alloc_size,
> > > + enum dma_data_direction dir, unsigned long attrs)
> > > {
> > > + dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, io_tlb_start);
> >
> > This is supposed to be hwdev, not dev
>
> Yeah, te compiler would be rather unhappy oterwise.
>
> I'll resend it after the dma-mapping and Xen trees are merged by Linus
> to avoid a merge conflict.
Sounds good, thanks. Please add
Reviewed-by: Stefano Stabellini <[email protected]>
