On 30.09.2020 12:41, Roger Pau Monne wrote: > This is code movement in order to simply further changes. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Acked-by: Jan Beulich <jbeul...@suse.com> albeit ... > --- a/xen/drivers/passthrough/io.c > +++ b/xen/drivers/passthrough/io.c > @@ -276,6 +276,92 @@ static struct vcpu *vector_hashing_dest(const struct > domain *d, > return dest; > } > > +static void hvm_pirq_eoi(struct pirq *pirq, > + const union vioapic_redir_entry *ent) > +{ > + struct hvm_pirq_dpci *pirq_dpci; > + > + if ( !pirq ) > + { > + ASSERT_UNREACHABLE(); > + return; > + } > + > + pirq_dpci = pirq_dpci(pirq); > + > + /* > + * No need to get vector lock for timer > + * since interrupt is still not EOIed > + */ > + if ( --pirq_dpci->pending || > + (ent && ent->fields.mask) || > + !pt_irq_need_timer(pirq_dpci->flags) ) > + return; > + > + stop_timer(&pirq_dpci->timer); > + pirq_guest_eoi(pirq); > +} > + > +static void __hvm_dpci_eoi(struct domain *d, ... could I talk you into dropping one of the two leading underscores while moving the thing? Jan