On 28/10/2020 10:28, Olaf Hering wrote: > Am Tue, 27 Oct 2020 23:18:47 +0000 > schrieb Andrew Cooper <[email protected]>: > >> I suspect we probably want an is_known_page_type() predicate on the >> source side to sanity check data from Xen, and on the destination side >> in handle_page_data() to sanity check data in the stream, and we >> probably want a page_type_has_data() predicate to use in >> write_batch()/process_page_data() to ensure that the handling is consistent. > From what I have seen, two (or three) helpers for sender and receiver will be > needed: > is_known_page_type() > is_data_page_type() > maybe is_ptbl_page_type() for normalise/localise.
Ah yes. That too. I would however recommend against the name is_data_page_type() because then the predicate is ambiguous with "== NOTAB". page_type_has_stream_data()? Its a bit of a mouthful, but the purpose is very clear. ~Andrew
signature.asc
Description: OpenPGP digital signature
