On 06/11/2020 14:35, Jan Beulich wrote: > On 06.11.2020 15:05, Juergen Gross wrote: >> Libxl bitmap operations for single bits (test, set, reset) take the bit >> number as a signed integer without testing the value to be larger than >> 0. >> >> Correct that by adding the appropriate tests. >> >> Signed-off-by: Juergen Gross <[email protected]> > Wouldn't it be better to convert the parameter types to unsigned int?
Yes, except their in the API, so immutable. (whether they should be in the API is a different question...) ~Andrew
