> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 12 November 2020 08:38 > To: Paul Durrant <p...@xen.org> > Cc: Durrant, Paul <pdurr...@amazon.co.uk>; Wei Liu <w...@xen.org>; Andrew > Cooper > <andrew.coop...@citrix.com>; Roger Pau Monné <roger....@citrix.com>; > xen-devel@lists.xenproject.org > Subject: RE: [EXTERNAL] [PATCH 02/10] viridian: move IPI hypercall > implementation into separate > function > > CAUTION: This email originated from outside of the organization. Do not click > links or open > attachments unless you can confirm the sender and know the content is safe. > > > > On 11.11.2020 21:07, Paul Durrant wrote: > > From: Paul Durrant <pdurr...@amazon.com> > > > > This patch moves the implementation of HVCALL_SEND_IPI that is currently > > inline in viridian_hypercall() into a new hvcall_ipi() function. > > > > The new function returns Xen errno values similarly to hvcall_flush(). Hence > > the errno translation code in viridial_hypercall() is generalized, removing > > the need for the local 'status' variable. > > > > NOTE: The formatting of the 'out' label also corrected as per CODING_STYLE > > How about correcting the adjacent switch() at the same time as well? >
Sure. > > and the code is adjusted to avoid a register copy-back if 'mode' is > > neither 8 nor 4. > > While you mention it here, isn't this an unrelated change wanting > its own justification? > It was such small mod that I folded it but maybe it would be best to break it out into a separate patch and also do the format adjustment there. Paul > Jan
