> -----Original Message----- > From: Oleksandr Andrushchenko <[email protected]> > Sent: 16 November 2020 10:34 > To: Paul Durrant <[email protected]>; [email protected] > Cc: Paul Durrant <[email protected]>; Anthony PERARD > <[email protected]>; Christian Lindig > <[email protected]>; David Scott <[email protected]>; George Dunlap > <[email protected]>; Ian Jackson <[email protected]>; Nick Rosbrook > <[email protected]>; > Wei Liu <[email protected]> > Subject: Re: [PATCH v2 00/24] xl / libxl: named PCI pass-through devices > > Hi, Paul! > > On 11/10/20 7:51 PM, Paul Durrant wrote: > > From: Paul Durrant <[email protected]> > > > > Paul Durrant (24): > > xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X > > libxl: use LIBXL_DEFINE_DEVICE_LIST for pci devices > > libxl: use LIBXL_DEFINE_DEVICE_LIST for nic devices > > libxl: s/detatched/detached in libxl_pci.c > > libxl: remove extraneous arguments to do_pci_remove() in libxl_pci.c > > libxl: stop using aodev->device_config in libxl__device_pci_add()... > > libxl: generalise 'driver_path' xenstore access functions in > > libxl_pci.c > > libxl: remove unnecessary check from libxl__device_pci_add() > > libxl: remove get_all_assigned_devices() from libxl_pci.c > > libxl: make sure callers of libxl_device_pci_list() free the list > > after use > > libxl: add libxl_device_pci_assignable_list_free()... > > libxl: use COMPARE_PCI() macro is_pci_in_array()... > > libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore > > libxl: Make sure devices added by pci-attach are reflected in the > > config > > docs/man: extract documentation of PCI_SPEC_STRING from the xl.cfg > > manpage... > > docs/man: improve documentation of PCI_SPEC_STRING... > > docs/man: fix xl(1) documentation for 'pci' operations > > libxl: introduce 'libxl_pci_bdf' in the idl... > > libxlu: introduce xlu_pci_parse_spec_string() > > libxl: modify > > libxl_device_pci_assignable_add/remove/list/list_free()... > > docs/man: modify xl(1) in preparation for naming of assignable devices > > xl / libxl: support naming of assignable devices > > docs/man: modify xl-pci-configuration(5) to add 'name' field to > > PCI_SPEC_STRING > > xl / libxl: support 'xl pci-attach/detach' by name > > > > docs/man/xl-pci-configuration.5.pod | 218 ++++++ > > docs/man/xl.1.pod.in | 39 +- > > docs/man/xl.cfg.5.pod.in | 68 +- > > tools/golang/xenlight/helpers.gen.go | 77 +- > > tools/golang/xenlight/types.gen.go | 8 +- > > tools/include/libxl.h | 67 +- > > tools/include/libxlutil.h | 8 +- > > tools/libs/light/libxl_create.c | 6 +- > > tools/libs/light/libxl_dm.c | 18 +- > > tools/libs/light/libxl_internal.h | 53 +- > > tools/libs/light/libxl_nic.c | 19 +- > > tools/libs/light/libxl_pci.c | 1030 ++++++++++++++------------ > > tools/libs/light/libxl_types.idl | 19 +- > > tools/libs/util/libxlu_pci.c | 379 +++++----- > > tools/ocaml/libs/xl/xenlight_stubs.c | 19 +- > > tools/xl/xl_cmdtable.c | 16 +- > > tools/xl/xl_parse.c | 28 +- > > tools/xl/xl_pci.c | 159 ++-- > > tools/xl/xl_sxp.c | 12 +- > > 19 files changed, 1308 insertions(+), 935 deletions(-) > > create mode 100644 docs/man/xl-pci-configuration.5.pod > > Patches 1-18: > > Reviewed-by: Oleksandr Andrushchenko <[email protected]> > > (I'll probably review more later as time allows). > > > I would like to ask the respective maintainers to look at this series as, in > the light of the > > upcoming changes for ARM PCI passthrough, these changes greatly help in > adapting the > > code for ARM >
FWIW, I believe there is still an issue in one of the patches (probably patch #14) which has caused problems for pass-through of multiple devices. I will debug that in the next couple of days and post v3. Paul > Thank you, > > Oleksandr > > > --- > > Cc: Anthony PERARD <[email protected]> > > Cc: Christian Lindig <[email protected]> > > Cc: David Scott <[email protected]> > > Cc: George Dunlap <[email protected]> > > Cc: Ian Jackson <[email protected]> > > Cc: Nick Rosbrook <[email protected]> > > Cc: Wei Liu <[email protected]>
