On 18.11.2020 18:38, Julien Grall wrote: > On 23/10/2020 11:17, Jan Beulich wrote: >> Build the source file always, as by putting it into an archive it still >> won't be linked into final binaries when not needed. This way possible >> build breakage will be easier to notice, and it's more consistent with >> us unconditionally building other library kind of code (e.g. sort() or >> bsearch()). >> >> While moving the source file, take the opportunity and drop the >> pointless EXPORT_SYMBOL(). >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > It looks like the commit message was duplicated.
Indeed - no idea how it has happened (also in at least one other patch in this series, as I've noticed now). >> Build the source file always, as by putting it into an archive it still >> won't be linked into final binaries when not needed. This way possible >> build breakage will be easier to notice, and it's more consistent with >> us unconditionally building other library kind of code (e.g. sort() or >> bsearch()). >> >> While moving the source file, take the opportunity and drop the >> pointless EXPORT_SYMBOL(). > > You are mentioning the EXPORT_SYMBOL() but... [...] >> --- a/xen/common/list_sort.c >> +++ b/xen/lib/list-sort.c >> @@ -15,7 +15,6 @@ >> * this program; If not, see <http://www.gnu.org/licenses/>. >> */ >> >> -#include <xen/lib.h> > > ... this is not mentionned. Well, not sure what to say. But anyway, I've added half a sentence to also mention this. Jan
