On 19.11.2020 16:54, Rahul Singh wrote: >> On 19 Nov 2020, at 10:16 am, Julien Grall <jul...@xen.org> wrote: >> On 19/11/2020 09:53, Jan Beulich wrote: >>> Well, see my patch suppressing building of quite a part of it. >> >> I will let Rahul figuring out whether your patch series is sufficient to fix >> compilation issues (this is what matters right now). > > I just checked the compilation error for ARM after enabling the HAS_PCI on > ARM. I am observing the same compilation error what I observed previously. > There are two new errors related to struct uart_config and struct part_param > as those struct defined globally but used under X86 flags. > > At top level: > ns16550.c:179:48: error: ‘uart_config’ defined but not used > [-Werror=unused-const-variable=] > static const struct ns16550_config __initconst uart_config[] = > ^~~~~~~~~~~ > ns16550.c:104:54: error: ‘uart_param’ defined but not used > [-Werror=unused-const-variable=] > static const struct ns16550_config_param __initconst uart_param[] = {
Looks like more code movement I need to do in my patch then. I was never happy about the disconnected placement of these array and the functions using them ... Jan