> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 20 November 2020 15:09
> To: Paul Durrant <p...@xen.org>
> Cc: Durrant, Paul <pdurr...@amazon.co.uk>; Wei Liu <w...@xen.org>; Andrew
> Cooper
> <andrew.coop...@citrix.com>; Roger Pau Monné <roger....@citrix.com>;
> xen-devel@lists.xenproject.org
> Subject: RE: [EXTERNAL] [PATCH v2 05/12] viridian: use hypercall_vpmask in
> hvcall_ipi()
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open
> attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On 20.11.2020 10:48, Paul Durrant wrote:
> > --- a/xen/arch/x86/hvm/viridian/viridian.c
> > +++ b/xen/arch/x86/hvm/viridian/viridian.c
> > @@ -551,6 +551,25 @@ static bool vpmask_test(const struct hypercall_vpmask
> > *vpmask,
> > return test_bit(vp, vpmask->mask);
> > }
> >
> > +static unsigned int vpmask_first(struct hypercall_vpmask *vpmask)
>
> Now this and ...
>
> > +{
> > + return find_first_bit(vpmask->mask, HVM_MAX_VCPUS);
> > +}
> > +
> > +static unsigned int vpmask_next(struct hypercall_vpmask *vpmask, unsigned
> > int vp)
>
> ... this should really have pointers to const as parameters.
>
> > @@ -631,13 +650,21 @@ static int hvcall_flush(union hypercall_input *input,
> > return 0;
> > }
> >
> > +static void send_ipi(struct hypercall_vpmask *vpmask, uint8_t vector)
>
> And I guess this one should, too.
>
True, they can be const.
Paul
> Jan
