Hello Julien, Thanks for reviewing the code.
> On 2 Dec 2020, at 1:44 pm, Julien Grall <jul...@xen.org> wrote: > > Hi Rahul, > > On 26/11/2020 17:02, Rahul Singh wrote: >> Linux SMMUv3 code implements the commands-queue insertion based on >> atomic operations implemented in Linux. Atomic functions used by the >> commands-queue insertion is not implemented in XEN therefore revert the >> patch that implemented the commands-queue insertion based on atomic >> operations. > > This commit message explains why we revert but not the consequence of the > revert. Can outline if there are any and why they are fine? Ok let me try to add more detail. > > I am also interested to have a list of *must* have for the driver to be out > of the tech preview. Ok let me add more informing in the commit message in next version of the patch. Regards, Rahul > > Cheers, > > -- > Julien Grall
