On 08.12.2020 14:51, Juergen Gross wrote: > With CONFIG_PV_SHIM_EXCLUSIVE some sources required for CONFIG_HVM are > not built, so let CONFIG_HVM depend on !CONFIG_PV_SHIM_EXCLUSIVE. > > Let CONFIG_HVM default to !CONFIG_PV_SHIM instead. > > Signed-off-by: Juergen Gross <[email protected]> > --- > xen/arch/x86/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
See "x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time" posted on Oct 19. I'd be fine switching to the !PV_SHIM default you have here. But Andrew looks to be objecting to a change like this, sadly without pointing out a good alternative so far. Jan > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 24868aa6ad..0107cfa12f 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -90,7 +90,8 @@ config PV_LINEAR_PT > If unsure, say Y. > > config HVM > - def_bool !PV_SHIM_EXCLUSIVE > + depends on !PV_SHIM_EXCLUSIVE > + def_bool !PV_SHIM > prompt "HVM support" > ---help--- > Interfaces to support HVM domains. HVM domains require hardware >
