On Fri, 11 Dec 2020 17:05:20 -0500 Eduardo Habkost <[email protected]> wrote:
> Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it will become a callback later. > > Reviewed-by: Stefan Berger <[email protected]> > Signed-off-by: Eduardo Habkost <[email protected]> > --- > Changes v1 -> v2: > * Removed unused variable at xen_block_set_vdev() > * Redone patch after changes in the previous patches in the > series > --- > Cc: Stefan Berger <[email protected]> > Cc: Stefano Stabellini <[email protected]> > Cc: Anthony Perard <[email protected]> > Cc: Paul Durrant <[email protected]> > Cc: Kevin Wolf <[email protected]> > Cc: Max Reitz <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: "Daniel P. Berrangé" <[email protected]> > Cc: Eduardo Habkost <[email protected]> > Cc: Cornelia Huck <[email protected]> > Cc: Halil Pasic <[email protected]> > Cc: Christian Borntraeger <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: David Hildenbrand <[email protected]> > Cc: Thomas Huth <[email protected]> > Cc: Matthew Rosato <[email protected]> > Cc: Alex Williamson <[email protected]> > Cc: Mark Cave-Ayland <[email protected]> > Cc: Artyom Tarasenko <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > backends/tpm/tpm_util.c | 6 -- > hw/block/xen-block.c | 6 -- > hw/core/qdev-properties-system.c | 70 ---------------------- > hw/core/qdev-properties.c | 100 ++++++------------------------- > hw/s390x/css.c | 6 -- > hw/s390x/s390-pci-bus.c | 6 -- > hw/vfio/pci-quirks.c | 6 -- > target/sparc/cpu.c | 6 -- > 8 files changed, 18 insertions(+), 188 deletions(-) Reviewed-by: Cornelia Huck <[email protected]>
