On 16/12/2020 02:27, osstest service owner wrote:
> branch xen-unstable-smoke
> xenbranch xen-unstable-smoke
> job build-amd64-libvirt
> testid libvirt-build
>
> Tree: libvirt git://xenbits.xen.org/libvirt.git
> Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen git://xenbits.xen.org/xen.git
> Bug introduced: 929f23114061a0089e6d63d109cf6a1d03d35c71
> Bug not present: 8bc342b043a6838c03cd86039a34e3f8eea1242f
> Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/157589/
>
>
> commit 929f23114061a0089e6d63d109cf6a1d03d35c71
> Author: Paul Durrant <[email protected]>
> Date: Tue Dec 8 19:30:26 2020 +0000
>
> libxl: introduce 'libxl_pci_bdf' in the idl...
>
> ... and use in 'libxl_device_pci'
>
> This patch is preparatory work for restricting the type passed to
> functions
> that only require BDF information, rather than passing a
> 'libxl_device_pci'
> structure which is only partially filled. In this patch only the minimal
> mechanical changes necessary to deal with the structural changes are
> made.
> Subsequent patches will adjust the code to make better use of the new
> type.
>
> Signed-off-by: Paul Durrant <[email protected]>
> Acked-by: Wei Liu <[email protected]>
> Acked-by: Nick Rosbrook <[email protected]>
This breaks the API. You can't make the following change in the IDL.
libxl_device_pci = Struct("device_pci", [
- ("func", uint8),
- ("dev", uint8),
- ("bus", uint8),
- ("domain", integer),
- ("vdevfn", uint32),
+ ("bdf", libxl_pci_bdf),
+ ("vdevfn", uint32),
~Andrew
