LGTM.
On Mon, Dec 14, 2020 at 05:36:07PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/call/netbsd.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c
> index a5502da377..1a771e9928 100644
> --- a/tools/libs/call/netbsd.c
> +++ b/tools/libs/call/netbsd.c
> @@ -19,12 +19,14 @@
> * Split from xc_netbsd.c
> */
>
> -#include "xc_private.h"
>
> #include <unistd.h>
> #include <fcntl.h>
> #include <malloc.h>
> +#include <errno.h>
> #include <sys/mman.h>
> +#include <sys/ioctl.h>
> +#include "private.h"
Please leave a newline before including private.h.
>
> int osdep_xencall_open(xencall_handle *xcall)
> {
> @@ -69,12 +71,13 @@ int osdep_xencall_close(xencall_handle *xcall)
> return close(fd);
> }
>
> -void *osdep_alloc_hypercall_buffer(xencall_handle *xcall, size_t npages)
> +void *osdep_alloc_pages(xencall_handle *xcall, size_t npages)
> {
> - size_t size = npages * XC_PAGE_SIZE;
> + size_t size = npages * PAGE_SIZE;
> void *p;
> + int ret;
>
> - ret = posix_memalign(&p, XC_PAGE_SIZE, size);
> + ret = posix_memalign(&p, PAGE_SIZE, size);
> if ( ret != 0 || !p )
> return NULL;
>
> @@ -86,14 +89,13 @@ void *osdep_alloc_hypercall_buffer(xencall_handle *xcall,
> size_t npages)
> return p;
> }
>
> -void osdep_free_hypercall_buffer(xencall_handle *xcall, void *ptr,
> - size_t npages)
> +void osdep_free_pages(xencall_handle *xcall, void *ptr, size_t npages)
> {
> - (void) munlock(ptr, npages * XC_PAGE_SIZE);
> + (void) munlock(ptr, npages * PAGE_SIZE);
I think you can drop the (void) cast here.
Thanks, Roger.
