On 19/01/2021 14:58, Roger Pau Monné wrote: > On Fri, Jan 15, 2021 at 11:10:45PM +0000, Andrew Cooper wrote: >> A subsequent change is going to introduce SKINIT support, wherein the APs >> will >> be already be in the wait-for-SIPI state, and an INIT must not be sent. >> >> Introduce a send_INIT boolean, so we can control sending an INIT IPI >> separately from sending SIPIs. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > I'm not opposed to introduce this, but maybe it would be better to > move it to a separate helper? send_init(unsigned int apicid); or some > such? > > Would reduce one level of indentation.
I've got a lot of cleanup planned for 4.16, but splitting this up INIT-SIPI-SIPI is specifically not one of them. This will get more complicated with Intel TXT Intel, and I also want to integrate it more nicely with the virtualised AP boot logic. I suspect we'll end up with a function pointer per platform&configuration, but that's too much work at this point in 4.15. ~Andrew
