Hi Michal, > On 21 Jan 2021, at 09:30, Michal Orzel <michal.or...@arm.com> wrote: > > Fix compilation error when enabling early printk, introduced > by commit aa4b9d1ee6538b5cbe218d4d3fcdf9548130a063: > ``` > debug.S: Assembler messages: > debug.S:31: Error: constant expression expected at operand 2 -- `ldr > x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))` > debug.S:38: Error: constant expression expected at operand 2 -- `ldr > x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))` > ``` > > The fix is to include header <xen/page-size.h> which now contains > definitions for page/size/mask etc. > > Signed-off-by: Michal Orzel <michal.or...@arm.com> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
Thanks a lot, this is fixing the compilation issues. Cheers Bertrand > --- > xen/include/asm-arm/early_printk.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/include/asm-arm/early_printk.h > b/xen/include/asm-arm/early_printk.h > index d5485decfa..8dc911cf48 100644 > --- a/xen/include/asm-arm/early_printk.h > +++ b/xen/include/asm-arm/early_printk.h > @@ -10,6 +10,7 @@ > #ifndef __ARM_EARLY_PRINTK_H__ > #define __ARM_EARLY_PRINTK_H__ > > +#include <xen/page-size.h> > > #ifdef CONFIG_EARLY_PRINTK > > -- > 2.29.0 >
